gstvg commented on code in PR #21950: URL: https://github.com/apache/datafusion/pull/21950#discussion_r3166448131
########## datafusion/core/src/execution/context/mod.rs: ########## Review Comment: https://github.com/apache/datafusion/pull/21950/commits/216542e76608196e71cea86e32be2d5986197606 I think that drop_function works on all functions not only those registered via a FunctionFactory, and I wrongly thought that adding that variant would require a lot of changes and tests, so I left it for a future PR, but I checked it now and it's all user defined and nothing had to be changed/added (this match is the only usage of the Aggregate, Window and Table variants, for example), thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
