nuno-faria commented on code in PR #21603:
URL: https://github.com/apache/datafusion/pull/21603#discussion_r3172906435


##########
datafusion/common/src/config.rs:
##########
@@ -3053,8 +3053,18 @@ impl From<ConfigFileDecryptionProperties> for 
FileDecryptionProperties {
 }

Review Comment:
   As a follow up, I wonder if the reverse should also be a `TryFrom`, since 
it's full of `unwraps`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to