neilconway commented on PR #21980: URL: https://github.com/apache/datafusion/pull/21980#issuecomment-4363969835
Thanks for the review, @comphead ! Please let me know if you have more feedback. FYI I think there's an opportunity to refactor this into an extension to the `StringViewArrayBuilder` API we just added (and perhaps use it in some other string UDFs), but I'd like to land this change first, so we can be sure the refactoring doesn't regress codegen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
