alamb commented on code in PR #22001: URL: https://github.com/apache/datafusion/pull/22001#discussion_r3183820585
########## benchmarks/sql_benchmarks/tpch/tpch.suite: ########## @@ -0,0 +1,16 @@ +name = "tpch" Review Comment: Why is this needed? It seems somewhat redundant with `SqlBenchmark`, yes? https://github.com/apache/datafusion/blob/dcd364ad9325c74ac445d740f62b22d4d6bf8507/benchmarks/src/sql_benchmark.rs#L45-L70 ########## benchmarks/Cargo.toml: ########## @@ -40,10 +40,11 @@ snmalloc = ["snmalloc-rs"] mimalloc_extended = ["libmimalloc-sys/extended"] [dependencies] +anstream = "1.0" Review Comment: I double checked and it seems like `anstream` is already a dependency of clap_builder, so this is not not a (net) new dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
