parthchandra opened a new pull request, #727: URL: https://github.com/apache/datafusion-comet/pull/727
## Which issue does this PR close? Part of [#679](https://github.com/apache/datafusion-comet/issues/679) and [#670](https://github.com/apache/datafusion-comet/issues/670) . ## Rationale for this change profiler output shows that with decimal128 enabled we have a bottleneck in `comet::common::bit::memcpy`. In addition when decimal128 is not enabled we use the `Int32ToDecimal64ColumnReader` reader for decimals with precision lower than 9. This results in a conversion call to `comet::parquet::read::values::copy_i32_to_i64` which shows up in the hot path. ## What changes are included in this PR? This PR changes the method to use `copy_nonoverlapped` for speed This PR attempts to use the `Int32ColumnReader` so that we do not incur any conversion costs. ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
