alamb commented on code in PR #11662:
URL: https://github.com/apache/datafusion/pull/11662#discussion_r1692871493
##########
datafusion/functions/src/utils.rs:
##########
@@ -41,8 +41,8 @@ macro_rules! get_optimal_return_type {
DataType::LargeUtf8 | DataType::LargeBinary => $largeUtf8Type,
// Binary inputs are automatically coerced to Utf8
DataType::Utf8 | DataType::Binary => $utf8Type,
- // Utf8View inputs will yield Utf8View outputs
- DataType::Utf8View => DataType::Utf8View,
+ // Utf8View max offset size is u32::MAX, the same as UTF8
Review Comment:
how did you find this? Can we add a test for it (e.g. an explain plan test
showing a change in type)?
I can help write one if you explain the symptoms you were seeing to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
