andygrove commented on code in PR #4182:
URL: https://github.com/apache/datafusion-comet/pull/4182#discussion_r3189990171
##########
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##########
@@ -761,6 +761,9 @@ class CometArrayExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelp
checkSparkAnswerAndOperator(sql("SELECT array_repeat(_4, null)
from t1"))
checkSparkAnswerAndOperator(sql("SELECT array_repeat(_4, 0) from
t1"))
+ checkSparkAnswerAndOperator(sql("SELECT array_repeat(_4, -1) from
t1"))
+ checkSparkAnswerAndOperator(
+ sql("SELECT array_repeat(cast(_3 as string), -5) from t1"))
Review Comment:
I think these cases were already covered in the Comet SQL Tests, but no harm
adding them here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
