andygrove commented on code in PR #4111:
URL: https://github.com/apache/datafusion-comet/pull/4111#discussion_r3190039551
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -33,7 +33,7 @@ import
org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProtoInter
object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
- override def getCompatibleNotes(): Seq[String] = Seq(
+ override def getIncompatibleReasons(): Seq[String] = Seq(
Review Comment:
Actually that was the wrong issue ... why does this PR rename this method?
There is no `getSupportLevel` so this expression is not marked as incompatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
