Michael-J-Ward commented on code in PR #771:
URL: https://github.com/apache/datafusion-python/pull/771#discussion_r1693046030
##########
python/datafusion/functions.py:
##########
@@ -1480,31 +1481,26 @@ def last_value(
)
-def bit_and(*args: Expr, distinct: bool = False) -> Expr:
+def bit_and(arg: Expr, distinct: bool = False) -> Expr:
"""Computes the bitwise AND of the argument."""
- args = [arg.expr for arg in args]
- return Expr(f.bit_and(*args, distinct=distinct))
+ return Expr(f.bit_and(arg.expr, distinct=distinct))
-def bit_or(*args: Expr, distinct: bool = False) -> Expr:
+def bit_or(arg: Expr, distinct: bool = False) -> Expr:
"""Computes the bitwise OR of the argument."""
- args = [arg.expr for arg in args]
- return Expr(f.bit_or(*args, distinct=distinct))
+ return Expr(f.bit_or(arg.expr, distinct=distinct))
-def bit_xor(*args: Expr, distinct: bool = False) -> Expr:
+def bit_xor(arg: Expr, distinct: bool = False) -> Expr:
"""Computes the bitwise XOR of the argument."""
- args = [arg.expr for arg in args]
- return Expr(f.bit_xor(*args, distinct=distinct))
+ return Expr(f.bit_xor(arg.expr, distinct=distinct))
-def bool_and(*args: Expr, distinct: bool = False) -> Expr:
+def bool_and(arg: Expr, distinct: bool = False) -> Expr:
"""Computes the boolean AND of the arugment."""
- args = [arg.expr for arg in args]
- return Expr(f.bool_and(*args, distinct=distinct))
+ return Expr(f.bool_and(arg.expr, distinct=distinct))
-def bool_or(*args: Expr, distinct: bool = False) -> Expr:
+def bool_or(arg: Expr, distinct: bool = False) -> Expr:
"""Computes the boolean OR of the arguement."""
- args = [arg.expr for arg in args]
- return Expr(f.bool_or(*args, distinct=distinct))
+ return Expr(f.bool_or(arg.expr, distinct=distinct))
Review Comment:
Nay - these wrappers were [correct for
v39](https://docs.rs/datafusion/39.0.0/datafusion/common/arrow/compute/fn.bit_and.html).
The `regr_*` functions were incorrect, though. But that led me to discover
that the tests for those are bypassing the wrappers:
https://github.com/apache/datafusion-python/issues/778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
