0lai0 commented on PR #3732:
URL:
https://github.com/apache/datafusion-comet/pull/3732#issuecomment-4385566144
Thanks for all the feedback! Here's a summary of the changes made:
- SQL test: Added window_time.sql with tumbling and sliding window
queries, including a NULL timestamp row.
- spark_answer_only: Kept for both queries. window() is internally
expanded by Spark's analyzer into a CreateNamedStruct wrapped in KnownNullable,
which Comet doesn't yet support, so a full fallback still occurs at the
operator level. The comment in the SQL file documents this explicitly.
- Docs: Added PreciseTimestampConversion / window_time to the supported
expressions table in expressions.md.
- Old Scala test: Removed in favor of the SQL-based test.
The PreciseTimestampConversion expression itself is now supported
natively. Full native execution of window_time queries will be unblocked once
KnownNullable is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
