iffyio commented on code in PR #2326:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2326#discussion_r3194799719
##########
tests/sqlparser_bigquery.rs:
##########
@@ -2203,6 +2203,35 @@ fn parse_big_query_declare() {
);
}
+#[test]
+fn parse_bigquery_create_external_table_with_connection_and_options() {
+ bigquery().one_statement_parses_to(
+ concat!(
+ "CREATE OR REPLACE EXTERNAL TABLE `proj.ds.tbl` ",
+ "WITH CONNECTION `projects/proj/locations/us/connections/c` ",
+ r#"OPTIONS(format = "ICEBERG", uris = ["gs://b/m.json"])"#,
+ ),
+ concat!(
+ "CREATE OR REPLACE EXTERNAL TABLE `proj`.`ds`.`tbl` () ",
+ "WITH CONNECTION `projects/proj/locations/us/connections/c` ",
+ r#"OPTIONS(format = "ICEBERG", uris = ["gs://b/m.json"])"#,
+ ),
+ );
+}
+
+#[test]
+fn parse_bigquery_create_external_table_with_connection_variants() {
Review Comment:
are the two functions testing different features? they look similar so that
if not they can be merged into the same function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
