alexanderbianchi opened a new pull request, #22041:
URL: https://github.com/apache/datafusion/pull/22041

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   The Substrait producer currently fails when a logical plan contains a 
`ScalarValue::Dictionary`, for example a string literal that was coerced to 
match a dictionary-encoded string column. Dictionary encoding is a physical 
representation detail; the Substrait literal should carry the logical inner 
value.
   
   ## What changes are included in this PR?
   
   This unwraps `ScalarValue::Dictionary(_, value)` in the Substrait literal 
producer and serializes the inner scalar value. It also adds a regression test 
showing a dictionary-encoded UTF8 scalar is emitted as a string literal and 
round trips as the logical UTF8 scalar.
   
   ## Are these changes tested?
   
   Yes:
   
   ```text
   cargo +1.91 test -p datafusion-substrait 
dictionary_literals_are_serialized_as_inner_values -- --nocapture
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to