andygrove opened a new pull request, #4243: URL: https://github.com/apache/datafusion-comet/pull/4243
## Which issue does this PR close? Closes #. ## Rationale for this change The fallback-chain prune step in `CometPlanStabilitySuite` was added in #4129 along with a regen for `spark3_5`, `spark4_0`, and `spark4_1`, but the `spark4_2` directory (added earlier in #4126) was never re-regenerated against the prune logic. As a result, most query directories under `approved-plans-v1_4-spark4_2/` and `approved-plans-v2_7-spark4_2/` are byte-identical duplicates of either the `spark4_1` directory or the base `approved-plans-v1_4` / `approved-plans-v2_7` directory. At read time the suite's fallback chain in `getDirForTest` already resolves to the appropriate copy, so these duplicates only add maintenance cost without changing test behavior. ## What changes are included in this PR? Re-runs `./dev/regenerate-golden-files.sh` (all Spark versions) on a clean checkout of `apache/main` and commits the resulting deletions. Net change: 262 `extended.txt` files removed across `approved-plans-v1_4-spark4_2/` and `approved-plans-v2_7-spark4_2/`. No other directories changed. The remaining `spark4_2` entries are queries whose plans actually differ from the `spark4_1` fallback: - `approved-plans-v1_4-spark4_2/`: q2, q5, q54 (each with `.native_datafusion` and `.native_iceberg_compat` variants). - `approved-plans-v2_7-spark4_2/`: 2 entries. ## How are these changes tested? `./dev/regenerate-golden-files.sh` ran for all five Spark versions (3.4, 3.5, 4.0, 4.1, 4.2) with `CometTPCDSV1_4_PlanStabilitySuite` and `CometTPCDSV2_7_PlanStabilitySuite`, all passing. The deletions reflect the suite's `pruneDuplicateQueryDirs` step, so the same suites continue to pass on the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
