Michael-J-Ward opened a new issue, #779: URL: https://github.com/apache/datafusion-python/issues/779
#750 added `python` wrappers instead of directly exposing `pyo3` generated code. We should leverage that to clean up and improve the rust codebase by: 1) Letting `python` wrappers handle any aliases. 2) Letting `python` wrappers handle any argument defaults, removing `#[pyo3(signature(...))]` annotations from the Rust codebase Additionally, we should provide guidance so that contributors understand the separation. @timsaucer [recommends](https://github.com/apache/datafusion-python/pull/771#discussion_r1693020654) the following guidelines (and I agree): > I think it's worth adding some guidance about what to put in python vs what to put in rust for this repo. In my mind the things that should go into the python side are > > * Trivial aliases (this is a good example) > * Simple type conversion, like path -> string of the path or number to lit(number) > * More complex type conversion if it makes sense to do in python. For example, in the named_struct where sending in a dictionary on the python side makes a lot more sense and isn't as simple to do via pyo3. > > And then I'd lean towards everything else sitting on the rust side. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
