parthchandra opened a new pull request, #4252:
URL: https://github.com/apache/datafusion-comet/pull/4252
These env vars are no longer set when running Spark SQL tests.
ENABLE_COMET_SCAN_ONLY is removed from all diffs (always enable exec+shuffle).
ENABLE_COMET_ANSI_MODE is removed from 3.4 and 3.5 diffs (ANSI mode has
dedicated tests in the Spark SQL suite).
## Which issue does this PR close?
Closes #2724
## Rationale for this change
Removes unused env variables and cleans up diff files.
## What changes are included in this PR?
- Removed `ENABLE_COMET_SCAN_ONLY` from all Spark diffs (3.4.3, 3.5.8,
4.0.2, 4.1.1) — this env var is no longer set when running Spark SQL tests, so
the conditional logic is dead code. The "exec+shuffle enabled" path is now
unconditional.
- Removed `ENABLE_COMET_ANSI_MODE` from the 3.4.3 and 3.5.8 diffs — this
only toggled spark.sql.ansi.enabled and doesn't enable any Comet features. ANSI
mode already has dedicated tests in the Spark SQL suite.
- Simplify `ParquetFilterSuite` guards from if (`!isCometEnabled ||
isCometScanOnly)` to if `(!isCometEnabled)`.
## How are these changes tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
