andygrove commented on code in PR #4244:
URL: https://github.com/apache/datafusion-comet/pull/4244#discussion_r3198443861
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -94,12 +94,9 @@ object CometConf extends ShimCometConf {
.createWithEnvVarOrDefault("ENABLE_COMET", true)
val COMET_NATIVE_SCAN_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.scan.enabled")
- .category(CATEGORY_SCAN)
- .doc(
- "Whether to enable native scans. When this is turned on, Spark will use
Comet to " +
- "read supported data sources (currently only Parquet is supported
natively). Note " +
- "that to enable native vectorized execution, both this config and " +
- "`spark.comet.exec.enabled` need to be enabled.")
+ .category(CATEGORY_TESTING)
+ .doc("Whether to enable native scans. Intended for use in Comet's own test
suites to " +
+ "selectively disable native scans; not intended for production use.")
Review Comment:
this is unrelated to 0.16 / spark 4 changes, but we don't want users using
this config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
