asolimando commented on PR #21870: URL: https://github.com/apache/datafusion/pull/21870#issuecomment-4394609722
> The benchmarks above show no measurable cost for the dispatch — my read is the localized change is the lower-risk path for this fix. If a separate canonicalization pre-pass lands later (to enable other rules that benefit from canonical leaves), `expr_contains_inner` can swing back to `==` then. Thanks @1fanwang for reporting your findings. If the benchmarks confirm that the localized change has acceptable runtime within the current usage pattern, I agree it's a practical way forward, and your analysis will be very useful for the future! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
