kosiew commented on code in PR #22039: URL: https://github.com/apache/datafusion/pull/22039#discussion_r3200006996
########## datafusion/sqllogictest/test_files/grouping.slt: ########## @@ -224,3 +224,22 @@ query I SELECT SUM(v1) FROM generate_series(10) AS t1(v1) GROUP BY GROUPING SETS(()) ---- 55 + +# grouping_sets_empty_input: GROUPING SETS (()) must produce one NULL row on empty input Review Comment: Nice addition to cover explicit `GROUPING SETS(())`. Since the optimizer change also protects `ROLLUP` and `CUBE` through `has_empty_grouping_set`, it would be great to add small empty-input regression cases for `ROLLUP(v1)` and `CUBE(v1)` as well. That would help lock in the full invariant covered by this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
