parthchandra commented on code in PR #732:
URL: https://github.com/apache/datafusion-comet/pull/732#discussion_r1693703925
##########
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -153,11 +153,7 @@ public CDataDictionaryProvider getDictionaryProvider() {
@Override
public boolean isNullAt(int rowId) {
- if (this.valueBufferAddress == -1) {
- return true;
- } else {
- return super.isNullAt(rowId);
- }
+ return this.valueBufferAddress == -1 || super.isNullAt(rowId);
Review Comment:
I would expect this to have identical performance to the original (i.e. this
should result in identical byte code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
