gstvg commented on code in PR #21193: URL: https://github.com/apache/datafusion/pull/21193#discussion_r3208848741
########## datafusion/substrait/tests/cases/roundtrip_logical_plan.rs: ########## Review Comment: That makes sense. Added one consumer test at https://github.com/apache/datafusion/pull/21193/changes/1fc0f05955d2c63327d528756acf3d5a8f86b3d5 and one producer test at https://github.com/apache/datafusion/pull/21193/changes/6cdfc056d90b81f4b85785df53c14344d48413ae, both using an expression with should cover all edge cases (nesting, [un]shadowing, column name conflict and outer references) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
