kosiew commented on code in PR #20047: URL: https://github.com/apache/datafusion/pull/20047#discussion_r3212211721
########## datafusion/sqllogictest/test_files/set_variable.slt: ########## @@ -605,6 +611,15 @@ SHOW datafusion.runtime.max_temp_directory_size ---- datafusion.runtime.max_temp_directory_size 10G +# Test SET and SHOW runtime.file_statistics_cache_limit +statement ok +SET datafusion.runtime.file_statistics_cache_limit = '42M' Review Comment: This SLT block sets `datafusion.runtime.file_statistics_cache_limit` and verifies it with `SHOW`, but it does not reset the value afterward. To avoid order-dependent behavior in later SLT statements, could we add: ```sql statement ok RESET datafusion.runtime.file_statistics_cache_limit ``` after the `SHOW` verification block? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
