kevinjqliu commented on code in PR #4275:
URL: https://github.com/apache/datafusion-comet/pull/4275#discussion_r3214065941
##########
dev/release/verify-release-candidate.sh:
##########
@@ -108,10 +108,12 @@ setup_tempdir() {
test_source_distribution() {
set -e
pushd native
- RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
+ cargo build --release ${COMET_CARGO_BUILD_ARGS:-}
Review Comment:
`RUSTFLAGS` not needed here, removing it so that it can be overriden by env
var in `verify-release-candidate.yml`
##########
dev/release/verify-release-candidate.sh:
##########
@@ -108,10 +108,12 @@ setup_tempdir() {
test_source_distribution() {
set -e
pushd native
- RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
+ cargo build --release ${COMET_CARGO_BUILD_ARGS:-}
popd
# test with the latest supported version of Spark
- ./mvnw verify -Prelease -DskipTests -P"spark-3.4"
-Dmaven.gitcommitid.skip=true
+ # Skip spotless since the source was already checked before release.
+ # Spotless can fail on Windows due to CRLF line ending differences.
+ ./mvnw verify -Prelease -DskipTests -P"spark-3.4"
-Dmaven.gitcommitid.skip=true -Dspotless.check.skip=true
Review Comment:
adds `-Dspotless.check.skip=true` here. The Spotless formatting plugin is
failing due to line ending differences (LF in the tarball vs CRLF expected on
Windows).
See
https://github.com/kevinjqliu/datafusion-comet/actions/runs/25614322434/job/75189622764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
