cyberbeam524 commented on code in PR #21714:
URL: https://github.com/apache/datafusion/pull/21714#discussion_r3214655584
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -272,8 +272,10 @@ impl LogicalPlanBuilder {
let n_cols = values[0].len();
let mut fields = ValuesFields::new();
for j in 0..n_cols {
- let field_type = schema.field(j).data_type();
- let field_nullable = schema.field(j).is_nullable();
+ let field = schema.field(j);
+ let field_type = field.data_type();
+ let field_nullable = field.is_nullable();
+ let field_metadata = FieldMetadata::new_from_field(field);
Review Comment:
Integrated check_metadata_with_storage_equal into infer_values_from_schema.
To avoid regressions in standard SQL types (like INT or BIGINT which often have
empty vs. None metadata mismatches during planning), I’ve gated this to trigger
only when the target is an extension type. The extension check and error string
formatting are done in the outer loop to maintain performance for large lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
