alamb commented on code in PR #22069:
URL: https://github.com/apache/datafusion/pull/22069#discussion_r3214723253
##########
datafusion/expr/src/utils.rs:
##########
@@ -339,7 +339,38 @@ fn get_excluded_columns(
idents.push(&excepts.first_element);
idents.extend(&excepts.additional_elements);
}
+ // Declared outside the `if let` so `idents.extend(exclude_owned.iter())`
+ // below can borrow references that outlive the inner scope.
+ #[cfg(feature = "sql")]
+ let exclude_owned: Vec<sqlparser::ast::Ident>;
if let Some(exclude) = opt_exclude {
+ #[cfg(feature = "sql")]
Review Comment:
> Why we need to keep parts of parser in DF? Maybe I'm missing something
I think the idea is to avoid a dependency on `sqlparser-rs` if you aren't
using the SQL interface
> For some users, adding in sqlparser greatly increases build times for
their projects even though they are not using sql. This feature makes sql an
optional dependency to improve build times and reduce the number of
dependencies.
I will propose some comments to make this celar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
