alrevuelta commented on code in PR #2333:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2333#discussion_r3218398699
##########
src/ast/query.rs:
##########
@@ -754,8 +754,9 @@ pub struct With {
pub with_token: AttachedToken,
/// Whether the `WITH` is recursive (`WITH RECURSIVE`).
pub recursive: bool,
- /// The list of CTEs declared by this `WITH` clause.
- pub cte_tables: Vec<Cte>,
+ /// The items declared by this `WITH` clause: traditional CTEs and,
+ /// for dialects that support it, named expressions.
Review Comment:
fixed
https://github.com/apache/datafusion-sqlparser-rs/pull/2333/changes/3b868426bd4f1cc15017efbc3648f1b7cfab4a2a#diff-ff51937f34d0076928ac31baffb41b26e4cbc0ec6dd8496105a7f61188f92ed1R757-R758
##########
src/ast/query.rs:
##########
@@ -754,8 +754,9 @@ pub struct With {
pub with_token: AttachedToken,
/// Whether the `WITH` is recursive (`WITH RECURSIVE`).
pub recursive: bool,
- /// The list of CTEs declared by this `WITH` clause.
- pub cte_tables: Vec<Cte>,
+ /// The items declared by this `WITH` clause: traditional CTEs and,
+ /// for dialects that support it, named expressions.
+ pub items: Vec<WithItem>,
Review Comment:
fixed
https://github.com/apache/datafusion-sqlparser-rs/pull/2333/changes/3b868426bd4f1cc15017efbc3648f1b7cfab4a2a#diff-ff51937f34d0076928ac31baffb41b26e4cbc0ec6dd8496105a7f61188f92ed1R757-R758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
