alamb commented on PR #21976:
URL: https://github.com/apache/datafusion/pull/21976#issuecomment-4421083625
> Thanks @alamb. Reading again I see two separate asks:
>
> * The inline on `new_tests.rs` (move it to
`datafusion/physical-optimizer/tests/ensure_requirements.rs`) is something I
can do inside this PR right away — will push that next.
> * The bigger one (move the existing
`core/tests/physical_optimizer/{enforce_distribution.rs, enforce_sorting.rs,
...}` integration tests, ~9.8k lines, to live alongside the optimizer crate) —
I'll do that as a separate prep PR after 54 ships, then rebase this on top so
the porting diff is clean.
>
> Will ping you when the inline fix lands and again when the prep PR is up.
Thanks @zhuqi-lucas
FYI I think we can reorganize the tests before 54 as that has a low chance
of introducing bugs (so doesn't need as long a "bake" time)
In terms of this PR, my plan for reviewing it is basically
1. Review what, if any tests have changed (will spend most effort here)
2. Run sql planning performance benchmarks to ensure no regressions
3. Review the code for anything that stands out
So TLDR is I plan to spend most of my time doing verification rather than
code review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
