EmilyMatt commented on code in PR #22064:
URL: https://github.com/apache/datafusion/pull/22064#discussion_r3219236466
##########
datafusion/physical-plan/src/aggregates/no_grouping.rs:
##########
@@ -370,6 +371,9 @@ impl AggregateStream {
Some(Err(e)) => Err(e),
None => {
this.finished = true;
+ // Release the input pipeline's resources before
finalization.
Review Comment:
I agree about the first part, as for the defensive stream, apparently it is
very a much a valid behaviour to re-poll a stream after it returns None, so I
wouldn't want to cause this error for a user, maybe in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
