JanKaul commented on code in PR #22050: URL: https://github.com/apache/datafusion/pull/22050#discussion_r3220167399
########## datafusion/optimizer/src/reorder_join/join_graph.rs: ########## @@ -0,0 +1,710 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::sync::Arc; + +use datafusion_common::{DataFusionError, NullEquality, Result, plan_err}; +use datafusion_expr::{ + Expr, JoinType, LogicalPlan, + utils::{check_all_columns_from_schema, split_conjunction_owned}, +}; + +pub type NodeId = usize; + +pub struct Node { + pub plan: Arc<LogicalPlan>, Review Comment: I think providing a "statistics" method only for [TableSource](https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.TableSource.html) already goes a long way. Typically the statistics are available through the wrapped "TableProvider" in DefaultTableSource. And you can see here: https://github.com/apache/datafusion/compare/main...Embucket:datafusion:reorder_join#diff-2489ffc0484dce93348e47735b64a9a319b5f82a24dacc842baee169067ad900 in "estimate_cardinality", this allows us to get some cardinality estimate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
