andygrove commented on code in PR #4267:
URL: https://github.com/apache/datafusion-comet/pull/4267#discussion_r3227376608
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -380,6 +380,46 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
+ val REGEXP_ENGINE_RUST = "rust"
+ val REGEXP_ENGINE_JAVA = "java"
+
+ val COMET_REGEXP_ENGINE: ConfigEntry[String] =
Review Comment:
Using the regexp work to test the new framework makes sense, but I think we
should split this work out into a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
