mbutrovich opened a new pull request, #4299:
URL: https://github.com/apache/datafusion-comet/pull/4299
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Discussion in https://github.com/apache/datafusion/pull/22026 highlighted
that Comet indiscriminately pushes filters into the scan without checking if
they can be pushed down. This doesn't lead to incorrect behavior because we
always have a FilterExec node above the scan anyway, so if any filters can't
actually be pushed down then we get evaluation above. DataFusion wants to
enforce a contract that `try_pushdown_filters` is called first, so let's adhere
to that. Eventually we might introduce an optimization to elide the FilterExec
if everything is successfully pushed down, but that's out of scope for this PR.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Call `try_pushdown_filters` instead of building the CNF of filters in Comet
and using `with_predicate`.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
