Rafferty97 commented on code in PR #11688:
URL: https://github.com/apache/datafusion/pull/11688#discussion_r1694204165
##########
datafusion/functions/src/core/named_struct.rs:
##########
@@ -165,3 +162,73 @@ impl ScalarUDFImpl for NamedStructFunc {
named_struct_expr(args)
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use arrow::array::{BooleanArray, Float64Array, Int64Array};
+ use datafusion_common::cast::as_struct_array;
+ use datafusion_common::ScalarValue;
+
+ #[test]
+ fn test_named_struct() {
+ // struct(1, 2.0, true) = { "foo": 1, "bar": 2.0, "baz": true }
Review Comment:
Okay, should the tests be removed then? I was following the lead of
`struct.rs`, so should the test in that file be removed too for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
