andygrove commented on PR #4274: URL: https://github.com/apache/datafusion-comet/pull/4274#issuecomment-4433696525
> > Thanks @andygrove we should also test nested types? > > Arrow/DataFusion doesn't really distinguish top-level columns from children, assuming you can bind the references in the first place. If we have any `CometScalarFunction`s binding correctly in the planner, all should work. That's something that should be tested generally, not for every arithmetic expression. For expressions that specifically handle nested types as their input types, then I agree. Ah, Spark actually does support complex types as parameters. I will add tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
