kosiew commented on code in PR #22106: URL: https://github.com/apache/datafusion/pull/22106#discussion_r3239545490
########## datafusion/expr/src/higher_order_function.rs: ########## Review Comment: This still asserts a bare `Vec<DataType>`, but `coerce_values_for_lambdas` now returns `Result<Option<Vec<DataType>>>`. Could you change the expected value to `Some(vec![...])` so readers copying the example see the current API shape? ########## datafusion/expr/src/type_coercion/functions.rs: ########## Review Comment: Small docs nit: this still describes lambda output coercion as being defined by the signature, but this PR now makes `coerce_values_for_lambdas` opt in by returning `Some(...)`. Could you update this and the sibling comment above `value_fields_with_higher_order_udf` to mention that the method is called and may return `None`? That would keep the public API docs aligned with the new invariant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
