athlcode commented on PR #22100: URL: https://github.com/apache/datafusion/pull/22100#issuecomment-4452014200
> Thanks @athlcode my bad, I just realized I haven't clarified tests needs to be added to `slt` file, lets remove rust tests unless they are not reproducible with `slt`. Ideally to create a separate `.slt` file for `explode_outer` to localize tests None of the test cases are currently reproducible via SLT because there's no SQL surface for NullHandling::PreserveAndExpandEmpty. To enable SLT coverage we need to add SQL recognition of explode_outer(col) (and probably explode(col) for symmetry) and map them to UNNEST with the right NullHandling variant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
