Dandandan opened a new pull request, #22186:
URL: https://github.com/apache/datafusion/pull/22186

   ## Which issue does this PR close?
   
   - Closes #22184.
   
   ## Rationale for this change
   
   The SQL planner should return an error for unsupported user SQL rather than 
panic. Unknown compound identifiers with six or more parts could reach an 
unchecked `unwrap()` after failing schema lookup.
   
   ## What changes are included in this PR?
   
   Updates compound identifier handling so unmatched identifiers with five or 
more parts return the existing `not_impl_err!` path instead of falling through 
to `form_identifier`.
   
   Adds a regression test for `SELECT a.b.c.d.e.f` to verify planning returns 
an unsupported compound identifier error.
   
   ## Are these changes tested?
   
   Yes:
   
   - `cargo fmt --all`
   - `cargo test -p datafusion-sql --test sql_integration 
select_unknown_deep_compound_identifier_returns_error`
   - `cargo clippy --all-targets --all-features -- -D warnings`
   
   ## Are there any user-facing changes?
   
   No API changes. Invalid deeply nested compound identifiers now return a 
planner error instead of panicking.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to