RyanJamesStewart commented on PR #22172: URL: https://github.com/apache/datafusion/pull/22172#issuecomment-4455314950
v2 pushed (72bea57): 1. `append_inline_view` is now `unsafe fn` with a `# Safety` paragraph spelling out what goes wrong if a non-inline view is passed (downstream `views` consumers interpret the high 96 bits as `[buffer_index, offset]` into the completed/in_progress buffers, which is unsound). The single call site in `insert_if_new_inner` is annotated with a `SAFETY:` comment pointing at the enclosing `if len <= 12` branch that establishes the invariant. 2. `benches/binary_view_map_insert.rs` removed along with the `[[bench]]` entry in the crate's Cargo.toml. Behavior unchanged. 8/8 binary_view_map tests pass; clippy + fmt clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
