xudong963 commented on PR #22191: URL: https://github.com/apache/datafusion/pull/22191#issuecomment-4457049452
Benchmark follow-up: I reran after the initial result showed 4 slower queries. In the rerun, Q19/Q24/Q26 were no longer flagged slower, only Q41 was slower with high branch-side variance, and total time was effectively unchanged (20310.89ms base vs 20314.91ms branch). TPCH/TPCDS also do not show a consistent regression. Given this PR only refactors setup code and preserves the decoder/page-pruning behavior, I think the clickbench signal is noise rather than a real regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
