SubhamSinghal commented on code in PR #21621:
URL: https://github.com/apache/datafusion/pull/21621#discussion_r3246056527
##########
datafusion/sqllogictest/test_files/push_down_topk_through_join.slt:
##########
Review Comment:
@kumarUjjawal I have added following test with random() function:
1. Non-deterministic sort expression (ORDER BY t1.b + random()) — verifies
no pushdown
2. Non-deterministic projected expression (random() AS col in sort) —
verifies no pushdown
3. Volatile expression inside a Projection of preserved child — verifies
pushdown IS safe (since random() is
materialized once by the Projection)
Are you looking for any other scenario for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
