waynexia commented on PR #22145:
URL: https://github.com/apache/datafusion/pull/22145#issuecomment-4457644142
I rerun it use an aws c6a.4xlarge instance. Improvement on q4 is reproduced,
but still has lots of regressions and some of them seem to be real. I'll verify
them on my local environment next
<details>
<summary>Details</summary>
```
Comparing HEAD and q4
--------------------
Benchmark clickbench_partitioned.json
--------------------
| Query | HEAD |
q4 | Change |
|-----------|--------------------------------------------|--------------------------------------------|---------------|
| QQuery 0 | 1.36 / 4.94 ±7.12 / 19.19 ms |
1.34 / 4.96 ±7.17 / 19.31 ms | no change |
| QQuery 1 | 16.62 / 19.50 ±5.12 / 29.72 ms | 16.31
/ 18.93 ±4.47 / 27.86 ms | no change |
| QQuery 2 | 49.02 / 56.98 ±13.18 / 83.28 ms | 49.78
/ 59.22 ±12.82 / 84.56 ms | no change |
| QQuery 3 | 53.17 / 413.82 ±718.84 / 1851.51 ms | 59.77 /
344.50 ±565.86 / 1476.22 ms | 1.12x slower |
| QQuery 4 | 554.10 / 563.18 ±8.72 / 578.19 ms | 439.19 /
580.67 ±129.14 / 769.30 ms | +1.26x faster |
| QQuery 5 | 516.88 / 862.42 ±659.98 / 2182.05 ms | 520.97 /
985.10 ±801.77 / 2584.76 ms | no change |
| QQuery 6 | 3.21 / 3.61 ±0.66 / 4.94 ms |
3.22 / 3.63 ±0.50 / 4.60 ms | no change |
| QQuery 7 | 17.74 / 17.93 ±0.21 / 18.32 ms | 17.66
/ 17.87 ±0.20 / 18.11 ms | no change |
| QQuery 8 | 686.29 / 696.36 ±5.83 / 703.40 ms | 754.21 /
1027.06 ±161.68 / 1242.22 ms | 1.10x slower |
| QQuery 9 | 728.66 / 774.36 ±46.60 / 853.92 ms | 757.98 /
773.33 ±27.82 / 828.94 ms | no change |
| QQuery 10 | 131.60 / 136.60 ±3.78 / 142.90 ms | 132.43 /
143.93 ±16.42 / 176.37 ms | no change |
| QQuery 11 | 154.82 / 157.99 ±3.68 / 164.70 ms | 154.22 /
157.11 ±2.27 / 160.61 ms | no change |
| QQuery 12 | 556.54 / 580.66 ±16.57 / 600.00 ms | 572.20 /
581.34 ±5.28 / 585.67 ms | no change |
| QQuery 13 | 910.76 / 925.92 ±11.40 / 942.69 ms | 917.47 /
1089.09 ±312.06 / 1711.62 ms | no change |
| QQuery 14 | 592.23 / 607.12 ±16.48 / 629.28 ms | 589.55 /
604.00 ±15.24 / 632.15 ms | no change |
| QQuery 15 | 660.31 / 668.69 ±7.57 / 680.85 ms | 660.65 /
698.46 ±57.26 / 811.65 ms | no change |
| QQuery 16 | 1379.80 / 1539.88 ±180.32 / 1779.23 ms | 1886.79 /
2404.33 ±589.74 / 3522.30 ms | 1.37x slower |
| QQuery 17 | 1354.58 / 1382.99 ±16.74 / 1399.85 ms | 1384.44 /
1492.35 ±176.97 / 1845.19 ms | no change |
| QQuery 18 | 3025.36 / 3872.99 ±884.61 / 5536.77 ms | 3199.56 /
4494.24 ±1372.71 / 7031.04 ms | 1.06x slower |
| QQuery 19 | 49.55 / 81.69 ±61.68 / 205.05 ms | 52.03 /
132.06 ±99.55 / 287.15 ms | no change |
| QQuery 20 | 819.85 / 4346.66 ±7038.47 / 18423.59 ms | 802.50 /
4260.38 ±6900.87 / 18062.11 ms | no change |
| QQuery 21 | 1000.17 / 1016.61 ±10.11 / 1031.33 ms | 1010.43 /
1068.85 ±45.61 / 1122.61 ms | no change |
| QQuery 22 | 2156.11 / 4996.83 ±5654.14 / 16305.09 ms | 2167.60 /
4980.96 ±5607.84 / 16196.63 ms | no change |
| QQuery 23 | 8584.84 / 24247.23 ±20717.36 / 60235.10 ms | 8519.57 /
17462.29 ±13228.65 / 42692.78 ms | no change |
| QQuery 24 | 74.87 / 79.44 ±3.41 / 85.18 ms | 72.72
/ 81.10 ±6.23 / 88.68 ms | no change |
| QQuery 25 | 178.34 / 183.73 ±7.06 / 197.70 ms | 169.92 /
173.68 ±2.34 / 177.19 ms | no change |
| QQuery 26 | 71.38 / 72.57 ±1.21 / 74.72 ms | 73.72
/ 75.13 ±1.16 / 76.90 ms | no change |
| QQuery 27 | 1192.07 / 1217.48 ±20.19 / 1242.67 ms | 1167.96 /
1187.36 ±21.54 / 1224.20 ms | no change |
| QQuery 28 | 3712.95 / 3738.42 ±30.59 / 3797.21 ms | 3625.79 /
3669.24 ±67.10 / 3801.25 ms | no change |
| QQuery 29 | 53.46 / 65.66 ±21.75 / 108.99 ms | 55.63
/ 59.62 ±5.05 / 68.61 ms | no change |
| QQuery 30 | 567.78 / 580.97 ±8.15 / 589.39 ms | 574.09 /
579.27 ±3.67 / 584.37 ms | no change |
| QQuery 31 | 703.23 / 716.17 ±19.01 / 753.59 ms | 704.20 /
714.94 ±6.34 / 721.92 ms | no change |
| QQuery 32 | 2717.58 / 3374.99 ±571.57 / 4437.74 ms | 3369.42 /
3940.48 ±562.65 / 4949.74 ms | 1.24x slower |
| QQuery 33 | 3161.04 / 3230.02 ±69.97 / 3363.47 ms | 3168.24 /
3310.67 ±178.75 / 3659.44 ms | no change |
| QQuery 34 | 3207.08 / 3409.06 ±234.38 / 3788.10 ms | 3190.32 /
3281.64 ±141.73 / 3562.07 ms | no change |
| QQuery 35 | 567.18 / 592.82 ±22.12 / 631.29 ms | 564.60 /
610.33 ±58.41 / 724.64 ms | no change |
| QQuery 36 | 83.78 / 94.23 ±7.04 / 102.23 ms | 82.21 /
93.46 ±12.43 / 117.60 ms | no change |
| QQuery 37 | 37.12 / 41.97 ±4.49 / 47.37 ms | 37.79
/ 42.43 ±4.74 / 49.52 ms | no change |
| QQuery 38 | 44.28 / 55.30 ±14.05 / 82.71 ms | 45.56
/ 52.01 ±4.13 / 58.37 ms | no change |
| QQuery 39 | 165.66 / 181.12 ±13.67 / 206.30 ms | 161.79 /
179.09 ±11.21 / 193.53 ms | no change |
| QQuery 40 | 18.57 / 22.00 ±3.40 / 26.49 ms | 18.39
/ 19.15 ±0.74 / 20.51 ms | no change |
| QQuery 41 | 17.78 / 21.30 ±3.95 / 28.81 ms | 17.61
/ 19.87 ±4.11 / 28.10 ms | no change |
| QQuery 42 | 14.75 / 19.02 ±4.93 / 27.30 ms | 14.79
/ 16.69 ±3.20 / 23.07 ms | no change |
| Benchmark Summary | |
|---|---:|
| Total Time (HEAD) | 40592.46ms |
| Total Time (q4) | 41784.61ms |
| Average Time (HEAD) | 944.01ms |
| Average Time (q4) | 971.74ms |
| Queries Faster | 1 |
| Queries Slower | 5 |
| Queries with No Change | 37 |
| Queries with Failure | 0 |
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
