milenkovicm commented on code in PR #1704:
URL:
https://github.com/apache/datafusion-ballista/pull/1704#discussion_r3247279919
##########
ballista-cli/src/tui/domain/jobs/stages.rs:
##########
@@ -114,36 +121,44 @@ impl JobStagesPopup {
}
pub fn scroll_down(&mut self) {
- let len = self.stages.stages.len();
- if len == 0 {
- self.table_state.select(None);
- return;
- }
- if let Some(selected) = self.table_state.selected() {
- if selected < len - 1 {
- self.table_state.select(Some(selected + 1));
- } else {
+ if self.is_no_details_view() {
+ let len = self.stages.stages.len();
+ if len == 0 {
self.table_state.select(None);
+ return;
}
- } else {
- self.table_state.select(Some(0));
+ if let Some(selected) = self.table_state.selected() {
+ if selected < len - 1 {
+ self.table_state.select(Some(selected + 1));
+ } else {
+ self.table_state.select(None);
+ }
+ } else {
+ self.table_state.select(Some(0));
+ }
+ } else if self.is_plan_view() {
+ self.scroll_position = self.scroll_position.saturating_add(1);
}
}
pub fn scroll_up(&mut self) {
Review Comment:
i believe we should be able to scroll to right / left as well, as some plans
can't really fit in allocated space, and get trimmed. I've noticed that with
text based plans?
would that be possible ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
