kazuyukitanimura commented on code in PR #4328:
URL: https://github.com/apache/datafusion-comet/pull/4328#discussion_r3249400779
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -127,6 +127,16 @@ object CometSparkSessionExtensions extends Logging {
return false
}
+ if (COMET_EXEC_SHUFFLE_REQUIRED.get(conf) &&
!isCometShuffleManagerEnabled(conf)) {
Review Comment:
We already have `COMET_EXEC_SHUFFLE_ENABLED`
What about disabling Comet when `COMET_EXEC_SHUFFLE_ENABLED.get(conf) &&
!isCometShuffleManagerEnabled(conf)` because that looks more like an user error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
