YutaLin opened a new pull request, #4348:
URL: https://github.com/apache/datafusion-comet/pull/4348

   ## Which issue does this PR close?
   
   Closes #3133 
   
   ## Rationale for this change
   Spark's CurrentTimeZone expression is declared `Unevaluable`. It walks the 
plan, finds every CurrentTimeZone, reads `SQLConf.get.sessionLocalTimeZone` at 
plan time, and substitutes a Literal(<that-string>, StringType) in place of the 
expression, so Comet would only see a Literal(String).
   
   We just need test and verify.
   
   ## What changes are included in this PR?
   Add `current_timezone.sql`
   
   ## How are these changes tested?
   run sql test in spark3.4/3.5/4.0 and prettier check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to