alamb commented on PR #11665:
URL: https://github.com/apache/datafusion/pull/11665#issuecomment-2256389441
> @alamb -- I cannot reproduce these test failures locally, even with the
same flags & tokio multithreaded tests enabled. Can you help?
I also could not reproduce it with
```
cargo test --lib -p datafusion-execution
```
One way to debug such failures is to add additional debug logging to the
tests -- right now the test failure simply says "failed" with a static message,
but it doesn't say what the actual result was
For example you could potentially update your asserts like this:
```diff
diff --git a/datafusion/execution/src/memory_pool/pool.rs
b/datafusion/execution/src/memory_pool/pool.rs
index 9ce14e41a..0df795a2b 100644
--- a/datafusion/execution/src/memory_pool/pool.rs
+++ b/datafusion/execution/src/memory_pool/pool.rs
@@ -494,12 +494,13 @@ mod tests {
// using the previously set sizes for other consumers
let mut r5 = MemoryConsumer::new("r5").register(&pool);
let expected = "Failed to allocate additional 150 bytes for r5 with
0 bytes already allocated - maximum available is 5. The top memory consumers
(across reservations) are: r1 consumed 50 bytes, r3 consumed 20 bytes, r2
consumed 15 bytes";
+ let actual_result = r5.try_grow(150);
assert!(
matches!(
- r5.try_grow(150),
+ actual_result,
Err(DataFusionError::ResourcesExhausted(e)) if
e.to_string().contains(expected)
),
- "should provide list of top memory consumers"
+ "should provide list of top memory consumers, got
{actual_result:?}",
);
}
```
And the message from your assertion failure should be more helpful for
debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
