kosiew commented on code in PR #22204: URL: https://github.com/apache/datafusion/pull/22204#discussion_r3252693837
########## datafusion/sql/src/statement.rs: ########## Review Comment: One small suggestion: consider validating `name` before planning `parameters`. Right now, nameless forms with non-literal arguments can still fail during parameter expression planning before reaching the missing-name check. Moving the `ok_or_else` earlier would make all nameless `EXECUTE` syntax return the same actionable error and would encode the invariant a bit earlier in the flow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
