timsaucer commented on PR #22151: URL: https://github.com/apache/datafusion/pull/22151#issuecomment-4478595780
As I was digging in, I found what I mentioned before wanting to change around. The root problem that I think needs to be reworked is making it so that we can pass `&dyn Session` instead of `&SessionState` in `create_physical_plan`. We'd need to move `QueryPlanner` up out of `core` so that we don't re-pollute the FFI crate. This means we need to add `optimize_physical_plan` to `Session` and a few other mechanical moving things around. If we did this then I think the entire approach in this crate would be a lot cleaner. I'm discovering right now that we also have an issue with the new scalar subquery data structure, so I've got my agent working away at that right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
