andygrove commented on PR #64: URL: https://github.com/apache/datafusion-java/pull/64#issuecomment-4479723323
> Makes sense to me! My bindings apparently solved/noticed this problem by [passing the row count](https://github.com/pgwhalen/datafusion-java/blob/1c20733aa8b008315af6092a912b58ef3df6a482/datafusion-ffi-java/src/main/java/org/apache/arrow/datafusion/logical_expr/ScalarUDF.java#L134) like the other PR. Unfortunately I missed that that was actually important in your PR and assumed that you just had a cleaner version. > > All the more reason to emulate the rust API closely. Thanks for the review! After chatting with @mbutrovich about making a similar change in Comet, he pointed out that we may still need row count in some cases, like for `uuid()` which has no input arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
