comphead commented on code in PR #4015:
URL: https://github.com/apache/datafusion-comet/pull/4015#discussion_r3261964327
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -368,6 +386,19 @@ object QueryPlanSerde extends Logging with CometExprShim
with CometTypeShim {
false
}
+ /**
+ * Returns true if the given data type is or contains a `MapType` at any
nesting level. Arrow's
+ * row format (used by DataFusion's grouped hash aggregate for composite
group keys) does not
+ * support `Map`, so grouping on any type that transitively contains a map
would crash in native
+ * execution.
+ */
+ def containsMapType(dt: DataType): Boolean = dt match {
Review Comment:
we already have this method in `operators.scala` we prob need to make this
method generic. I'll check it in followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
