alamb commented on PR #11627: URL: https://github.com/apache/datafusion/pull/11627#issuecomment-2258088889
This seems to repeatably help TPCH sf1 queries ``` Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ skip-partial-aggregation ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 353.98ms │ 338.33ms │ no change │ │ QQuery 2 │ 134.67ms │ 121.64ms │ +1.11x faster │ │ QQuery 3 │ 171.66ms │ 163.05ms │ +1.05x faster │ │ QQuery 4 │ 107.33ms │ 99.12ms │ +1.08x faster │ │ QQuery 5 │ 201.11ms │ 202.13ms │ no change │ │ QQuery 6 │ 86.90ms │ 91.13ms │ no change │ │ QQuery 7 │ 285.15ms │ 278.44ms │ no change │ │ QQuery 8 │ 204.50ms │ 198.24ms │ no change │ │ QQuery 9 │ 314.07ms │ 307.18ms │ no change │ │ QQuery 10 │ 275.17ms │ 266.16ms │ no change │ │ QQuery 11 │ 103.05ms │ 103.35ms │ no change │ │ QQuery 12 │ 158.16ms │ 151.71ms │ no change │ │ QQuery 13 │ 320.99ms │ 314.32ms │ no change │ │ QQuery 14 │ 121.03ms │ 114.29ms │ +1.06x faster │ │ QQuery 15 │ 171.95ms │ 170.98ms │ no change │ │ QQuery 16 │ 98.15ms │ 97.62ms │ no change │ │ QQuery 17 │ 317.55ms │ 324.36ms │ no change │ │ QQuery 18 │ 420.98ms │ 437.37ms │ no change │ │ QQuery 19 │ 198.55ms │ 197.32ms │ no change │ │ QQuery 20 │ 195.25ms │ 178.38ms │ +1.09x faster │ │ QQuery 21 │ 340.32ms │ 336.45ms │ no change │ │ QQuery 22 │ 72.91ms │ 70.21ms │ no change │ └──────────────┴───────────┴──────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 4653.44ms │ │ Total Time (skip-partial-aggregation) │ 4561.77ms │ │ Average Time (main_base) │ 211.52ms │ │ Average Time (skip-partial-aggregation) │ 207.35ms │ │ Queries Faster │ 5 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 17 │ └─────────────────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
