kazuyukitanimura commented on code in PR #4019:
URL: https://github.com/apache/datafusion-comet/pull/4019#discussion_r3262456550
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -1705,99 +1704,28 @@ class ParquetReadV1Suite extends ParquetReadSuite with
AdaptiveSparkPlanHelper {
test("Test V1 parquet scan uses respective scanner") {
Seq(
("false", CometConf.SCAN_NATIVE_DATAFUSION, "FileScan parquet"),
- ("true", CometConf.SCAN_NATIVE_DATAFUSION, "CometNativeScan"),
- ("true", CometConf.SCAN_NATIVE_ICEBERG_COMPAT, "CometScan
[native_iceberg_compat] parquet"))
- .foreach { case (cometEnabled, cometNativeScanImpl, expectedScanner) =>
+ ("true", CometConf.SCAN_NATIVE_DATAFUSION, "CometNativeScan")).foreach {
+ case (cometEnabled, cometNativeScanImpl, expectedScanner) =>
testScanner(
cometEnabled,
cometNativeScanImpl,
scanner = expectedScanner,
v1 = Some("parquet"))
- }
+ }
}
test("test V1 parquet native scan -- case insensitive") {
withTempPath { path =>
spark.range(10).toDF("a").write.parquet(path.toString)
- Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach(
- scanMode => {
- withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> scanMode) {
- withTable("test") {
- sql("create table test (A long) using parquet options (path '" +
path + "')")
- val df = sql("select A from test")
- checkSparkAnswer(df)
- // TODO: pushed down filters do not used schema adapter in
datafusion, will cause empty result
- // val df = sql("select * from test where A > 5")
- // checkSparkAnswer(df)
- }
- }
- })
- }
- }
-
- test("test V1 parquet scan filter pushdown of primitive types uses
native_iceberg_compat") {
- withTempPath { dir =>
- val path = new Path(dir.toURI.toString, "test1.parquet")
- val rows = 1000
- withSQLConf(
- CometConf.COMET_NATIVE_SCAN_IMPL.key ->
CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
- CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.key -> "true") {
- makeParquetFileAllPrimitiveTypes(
- path,
- dictionaryEnabled = false,
- 0,
- rows,
- nullEnabled = false)
- }
- Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach {
Review Comment:
We should be able to keep this test for SCAN_NATIVE_DATAFUSION?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
