alamb commented on code in PR #11714:
URL: https://github.com/apache/datafusion/pull/11714#discussion_r1696852266
##########
datafusion/sql/src/utils.rs:
##########
@@ -287,6 +287,28 @@ pub(crate) fn value_to_string(value: &Value) ->
Option<String> {
}
}
+pub(crate) fn transform_bottom_unnests(
+ input: &LogicalPlan,
+ unnest_placeholder_columns: &mut Vec<String>,
+ inner_projection_exprs: &mut Vec<Expr>,
+ original_exprs: &[Expr],
+) -> Result<Vec<Expr>> {
+ Ok(original_exprs
Review Comment:
This does the recursion manually -- I wonder if it would be possible /
useful to do the recursion using `transform_up` from TreeNode:
https://docs.rs/datafusion/latest/datafusion/common/tree_node/trait.TreeNode.html#method.transform_up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
